Skip to content

Fix several function name related issues #3848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbatyai merged 1 commit into from
Jun 4, 2020
Merged

Fix several function name related issues #3848

dbatyai merged 1 commit into from
Jun 4, 2020

Conversation

@rerobika
Copy link
Member

@rerobika rerobika commented Jun 4, 2020

  • For non-computed name script functions only identifier/string literal should be set as name
  • Implicit class constructor names with non string function name should be ToString-ed

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

@rerobika
Fix several function name related issues
2c47e3c 
 - For non-computed name srcipt functions only identifier/string literal should be set as name
 - Implicit class constructor names with non string function name should be ToString-ed

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
@rerobika rerobika added the bug Undesired behaviour label Jun 4, 2020
@rerobika
Copy link
Member Author

rerobika commented Jun 4, 2020

Note: The issues were found by Fuzzinator with grammarinator.

zherczeg
zherczeg approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dbatyai
dbatyai approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit c09c2c5 into jerryscript-project:master Jun 4, 2020
@rerobika rerobika deleted the fix_function_name branch June 16, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zherczeg zherczeg zherczeg approved these changes

@dbatyai dbatyai dbatyai approved these changes

Assignees

No one assigned

Labels

bug Undesired behaviour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rerobika @zherczeg @dbatyai